[ 
https://issues.apache.org/jira/browse/ARROW-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133138#comment-16133138
 ] 

Jacques Nadeau commented on ARROW-1361:
---------------------------------------

I'm not sure your particular use case.... 

In general, I feel like the arrow pojo/field APIs are very inadequate. We built 
something up at Dremio to try to improve the behavior/consolidate typical 
handling tasks. We've discussed how much of it would be generally useful but 
have yet to come up with a solution. Would love your thoughts on whether any 
portion of what we did would be generally helpful. Our work against Arrow 
types: 
https://github.com/dremio/dremio-oss/blob/master/sabot/logical/src/main/java/com/dremio/common/expression/CompleteType.java



> [Java] Add minor type param accessors to NullableValueVectors
> -------------------------------------------------------------
>
>                 Key: ARROW-1361
>                 URL: https://issues.apache.org/jira/browse/ARROW-1361
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Java - Vectors
>            Reporter: Bryan Cutler
>            Assignee: Bryan Cutler
>
> A {{NullableValueVector}} creates private copies of each param in the minor 
> type, but does not have any way public api to access them.  So if given a 
> {{NullableValueVector}} you would have to use the {{Field}} and cast to the 
> correct type.  For example, with a {{NullableTimeStampMicroTZVector}} and 
> trying to get the timezone:
> {noformat}
> if field.getType.isInstanceOf[ArrowType.Timestamp] &&
>           field.getType.asInstanceOf[ArrowType.Timestamp].getTimezone
> {noformat}
> It would be more convenient to have direct accessors for these type params.  
> Also, it is possible to do some minor refactoring because 
> {{NullableValueVectors}} does not use these type params, so there is no need 
> to store them.  They already exist in the inner vector object and the Field 
> type.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to