[ 
https://issues.apache.org/jira/browse/ARROW-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213630#comment-16213630
 ] 

ASF GitHub Bot commented on ARROW-1409:
---------------------------------------

GitHub user wesm opened a pull request:

    https://github.com/apache/arrow/pull/1225

    ARROW-1409: [Format] Remove page id from Buffer metadata, increment 
metadata version number

    This is a breaking metadata change per discussion on the mailing list. I 
expect this kind of truly breaking changes to be exceedingly rare going 
forward, and when we make a 1.0.0 release we should document expectations 
around metadata / memory format stability. 
    
    This could be made backwards compatible with some effort (we would have to 
add `RecordBatchV3` and `BufferV3` types). 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wesm/arrow ARROW-1409

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/arrow/pull/1225.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1225
    
----
commit c6fb115e75a452aa73478874013f691693c8c9ec
Author: Wes McKinney <wes.mckin...@twosigma.com>
Date:   2017-10-21T01:13:16Z

    Remove page id from Buffer metadata, increment metadata version number
    
    Change-Id: I731fa4c54a597fa48eefe88fb47755077b159114

commit 316a50bd51c36cc84e6c691e72a31f4928316f2a
Author: Wes McKinney <wes.mckin...@twosigma.com>
Date:   2017-10-21T01:20:18Z

    Bump metadata version in Java, add check for V4
    
    Change-Id: Ie41bf47bcc81f5f27dc441988aa19fc94e7bb047

----


> [Format] Use for "page" attribute in Buffer in metadata
> -------------------------------------------------------
>
>                 Key: ARROW-1409
>                 URL: https://issues.apache.org/jira/browse/ARROW-1409
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Format
>            Reporter: Wes McKinney
>              Labels: pull-request-available
>             Fix For: 0.8.0
>
>
> This attribute is currently unused in any Arrow implementation. I think the 
> original idea is that the "page" might indicate a particular shared memory 
> page, so that a record batch could be spread across multiple memory regions.
> The downside of this unused attribute is that Buffer metadata takes 24 bytes 
> instead of 16 due to padding. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to