[ https://issues.apache.org/jira/browse/ARROW-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215273#comment-16215273 ]
ASF GitHub Bot commented on ARROW-1474: --------------------------------------- icexelloss commented on issue #1203: ARROW-1474:[WIP] Java Vector Refactor (Implementation Phase 2) URL: https://github.com/apache/arrow/pull/1203#issuecomment-338690930 @siddharthteotia , thanks for the explanation. **W.r.t introduction of some static interfaces for JsonFileWriter/Reader** I see, so the reason is inner vectors are removed and therefore the json reader/writer doesn't work anymore. In that case, I am sort of OK with leaving these methods as public static but document clearly those methods are not part of public API and should not be used (IMHO "not recommended" is not strong enough, I would probably say "shouldn't") and refactor that later, before or after 0.8 release. What do other people think? **W.r.t introduction of some new APIs in ValueVector** > So I introduced APIs like getNullCount(), getValueCount(), setValueCount(), getObject() for the new nullable vectors. Once we remove non-nullable vectors and expose mutator/accessor functions as direct get/set in ValueVector, we can get rid of these APIs too. > User is free to call such methods on vectors @siddharthteotia, let me see if I understand this correctly: getNullCount(), getValueCount(), setValueCount(), getObject() are a part of the new vector API and we will keep them going forward. I think I saw a version of the BaseValueVector that these methods are returning bogus values and got confused. It seems to be correct row. I probably just saw a wip version. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [JAVA] ValueVector hierarchy (Implementation Phase 2) > ----------------------------------------------------- > > Key: ARROW-1474 > URL: https://issues.apache.org/jira/browse/ARROW-1474 > Project: Apache Arrow > Issue Type: Sub-task > Reporter: Jacques Nadeau > Assignee: Siddharth Teotia > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v6.4.14#64029)