[
https://issues.apache.org/jira/browse/ARROW-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218993#comment-16218993
]
ASF GitHub Bot commented on ARROW-1723:
---------------------------------------
JohnPJenkins commented on issue #1244: ARROW-1723: [C++] add ARROW_STATIC to
mark static libs on Windows
URL: https://github.com/apache/arrow/pull/1244#issuecomment-339387674
Reworked the commit based on discussion - Windows builds now use separate
compilation with a conditional ARROW_STATIC macro for static and shared library
targets (Unix remains the same).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Windows: __declspec(dllexport) specified when building arrow static library
> ---------------------------------------------------------------------------
>
> Key: ARROW-1723
> URL: https://issues.apache.org/jira/browse/ARROW-1723
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: John Jenkins
> Labels: pull-request-available
>
> As I understand it, dllexport/dllimport should be left out when building and
> using static libraries on Windows. A PR will follow shortly.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
