[
https://issues.apache.org/jira/browse/ARROW-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222500#comment-16222500
]
ASF GitHub Bot commented on ARROW-1728:
---------------------------------------
wesm commented on issue #1251: ARROW-1728: [C++] Run clang-format checks in
Travis CI
URL: https://github.com/apache/arrow/pull/1251#issuecomment-339995039
Now that we have gitbox unless contributors uncheck the "allow edits from
maintainers" box, we can also do the clang-format ourselves if that's blocking
a time-sensitive PR getting merged. The one downside is that getting the right
version of clang-format on Windows and macOS may be more work than on Linux; we
probably should add instructions to help contributors
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Run clang-format checks in Travis CI
> ------------------------------------------
>
> Key: ARROW-1728
> URL: https://issues.apache.org/jira/browse/ARROW-1728
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Assignee: Wes McKinney
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> I think it's reasonable to expect contributors to run clang-format on their
> code. This may lead to a higher number of failed builds but will eliminate
> noise diffs in unrelated patches
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
