[
https://issues.apache.org/jira/browse/ARROW-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222787#comment-16222787
]
ASF GitHub Bot commented on ARROW-1663:
---------------------------------------
BryanCutler commented on a change in pull request #1193: ARROW-1663: use
consistent name for null and not-null in FixedSizeLis…
URL: https://github.com/apache/arrow/pull/1193#discussion_r147513485
##########
File path:
java/vector/src/test/java/org/apache/arrow/vector/TestListVector.java
##########
@@ -633,11 +633,11 @@ public void testGetBufferAddress() throws Exception {
public void testConsistentChildName() throws Exception {
try (ListVector listVector = ListVector.empty("sourceVector", allocator)) {
String emptyListStr = listVector.getField().toString();
- assertTrue(emptyListStr.contains(ListVector.DATA_VECTOR_NAME));
+ Assert.assertTrue(emptyListStr.contains(ListVector.DATA_VECTOR_NAME));
- listVector.addOrGetVector(FieldType.nullable(MinorType.INT.getType()));
+
listVector.addOrGetVector(FieldType.nullable(Types.MinorType.INT.getType()));
String emptyVectorStr = listVector.getField().toString();
- assertTrue(emptyVectorStr.contains(ListVector.DATA_VECTOR_NAME));
+ Assert.assertTrue(emptyVectorStr.contains(ListVector.DATA_VECTOR_NAME));
Review comment:
The rest of the tests in this file match the way it was previously. If
you're going to change it here then I would prefer making the others consistent
as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Java] Follow up on ARROW-1347 and make schema backward compatible
> ------------------------------------------------------------------
>
> Key: ARROW-1663
> URL: https://issues.apache.org/jira/browse/ARROW-1663
> Project: Apache Arrow
> Issue Type: Bug
> Components: Java - Vectors
> Reporter: Yuliya Feldman
> Assignee: Yuliya Feldman
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> ARROW-1347 covered ListVector to have name of the field $data$ instead of
> [DEFAULT]
> We left FixedSizeListVector behind.
> Another case is backward compatibility - if schema was created before
> ARROW-1347 was in place application may still suffer from side effects as it
> would not be updated based on new code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
