[
https://issues.apache.org/jira/browse/ARROW-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225493#comment-16225493
]
ASF GitHub Bot commented on ARROW-1559:
---------------------------------------
wesm commented on a change in pull request #1266: WIP: ARROW-1559: Add unique
kernel
URL: https://github.com/apache/arrow/pull/1266#discussion_r147788617
##########
File path: cpp/src/arrow/builder.cc
##########
@@ -815,48 +815,35 @@ Status BooleanBuilder::Append(const std::vector<bool>&
values) {
}
// ----------------------------------------------------------------------
-// DictionaryBuilder
+// UniqueBuilder
template <typename T>
-DictionaryBuilder<T>::DictionaryBuilder(const std::shared_ptr<DataType>& type,
- MemoryPool* pool)
+UniqueBuilder<T>::UniqueBuilder(const std::shared_ptr<DataType>& type,
MemoryPool* pool)
: ArrayBuilder(type, pool),
Review comment:
We may reach a point where it doesn't make sense to inherit from
ArrayBuilder, and rather compose it (or not use it at all)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Kernel implementations for "unique" (compute distinct elements of array)
> ------------------------------------------------------------------------------
>
> Key: ARROW-1559
> URL: https://issues.apache.org/jira/browse/ARROW-1559
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
> Reporter: Wes McKinney
> Assignee: Uwe L. Korn
> Labels: Analytics, pull-request-available
> Fix For: 0.8.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
