[
https://issues.apache.org/jira/browse/ARROW-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236619#comment-16236619
]
ASF GitHub Bot commented on ARROW-1663:
---------------------------------------
yufeldman commented on a change in pull request #1193: ARROW-1663: use
consistent name for null and not-null in FixedSizeLis…
URL: https://github.com/apache/arrow/pull/1193#discussion_r148664452
##########
File path:
java/vector/src/main/java/org/apache/arrow/vector/types/pojo/Field.java
##########
@@ -47,6 +49,8 @@
public class Field {
+ public static final String ZEROVECTOR_OLD_NAME = "[DEFAULT]";
Review comment:
mutateOriginalNameIfNeeded may be invoked many times. I understand that
compiler will optimize it, but I am not sure it makes sense to multiply
"[DEFAULT]". May be place to keep this const is not a great one, I would prefer
to keep it in ZeroVector - at least it has some association with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Java] Follow up on ARROW-1347 and make schema backward compatible
> ------------------------------------------------------------------
>
> Key: ARROW-1663
> URL: https://issues.apache.org/jira/browse/ARROW-1663
> Project: Apache Arrow
> Issue Type: Bug
> Components: Java - Vectors
> Reporter: Yuliya Feldman
> Assignee: Yuliya Feldman
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> ARROW-1347 covered ListVector to have name of the field $data$ instead of
> [DEFAULT]
> We left FixedSizeListVector behind.
> Another case is backward compatibility - if schema was created before
> ARROW-1347 was in place application may still suffer from side effects as it
> would not be updated based on new code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
