[
https://issues.apache.org/jira/browse/ARROW-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241424#comment-16241424
]
ASF GitHub Bot commented on ARROW-1771:
---------------------------------------
wesm closed pull request #1288: ARROW-1771: [C++] ARROW-1749 Breaks Public API
test in parquet-cpp
URL: https://github.com/apache/arrow/pull/1288
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cpp/src/arrow/CMakeLists.txt b/cpp/src/arrow/CMakeLists.txt
index 22b475146..69d505233 100644
--- a/cpp/src/arrow/CMakeLists.txt
+++ b/cpp/src/arrow/CMakeLists.txt
@@ -171,6 +171,7 @@ ADD_ARROW_TEST(array-test)
ADD_ARROW_TEST(buffer-test)
ADD_ARROW_TEST(memory_pool-test)
ADD_ARROW_TEST(pretty_print-test)
+ADD_ARROW_TEST(public-api-test)
ADD_ARROW_TEST(status-test)
ADD_ARROW_TEST(type-test)
ADD_ARROW_TEST(table-test)
diff --git a/cpp/src/arrow/public-api-test.cc b/cpp/src/arrow/public-api-test.cc
new file mode 100644
index 000000000..8298d748f
--- /dev/null
+++ b/cpp/src/arrow/public-api-test.cc
@@ -0,0 +1,26 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "arrow/api.h"
+
+#ifdef DCHECK
+#error "DCHECK should not be visible from Arrow public headers."
+#endif
+
+#include <gtest/gtest.h>
+
+TEST(_, _) {}
diff --git a/cpp/src/arrow/util/bit-util.h b/cpp/src/arrow/util/bit-util.h
index d6415f3c7..cab3c9ee7 100644
--- a/cpp/src/arrow/util/bit-util.h
+++ b/cpp/src/arrow/util/bit-util.h
@@ -57,7 +57,6 @@
#include <memory>
#include <vector>
-#include "arrow/util/logging.h"
#include "arrow/util/macros.h"
#include "arrow/util/type_traits.h"
#include "arrow/util/visibility.h"
@@ -301,7 +300,7 @@ static inline int Log2(uint64_t x) {
/// \brief Count the number of leading zeros in a 32 bit integer.
static inline int64_t CountLeadingZeros(uint32_t value) {
- DCHECK_NE(value, 0);
+// DCHECK_NE(value, 0);
#if defined(__clang__) || defined(__GNUC__)
return static_cast<int64_t>(__builtin_clz(value));
#elif defined(_MSC_VER)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] ARROW-1749 Breaks Public API test in parquet-cpp
> ------------------------------------------------------
>
> Key: ARROW-1771
> URL: https://issues.apache.org/jira/browse/ARROW-1771
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Affects Versions: 0.7.1
> Reporter: Phillip Cloud
> Assignee: Phillip Cloud
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
