[ https://issues.apache.org/jira/browse/ARROW-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242944#comment-16242944 ]
ASF GitHub Bot commented on ARROW-972: -------------------------------------- wesm commented on a change in pull request #1216: ARROW-972: UnionArray in pyarrow URL: https://github.com/apache/arrow/pull/1216#discussion_r149509888 ########## File path: cpp/src/arrow/array.h ########## @@ -612,12 +612,43 @@ class ARROW_EXPORT UnionArray : public Array { const std::shared_ptr<Buffer>& null_bitmap = NULLPTR, int64_t null_count = 0, int64_t offset = 0); + /// \brief Construct Dense UnionArray from types_ids, value_offsets and children + /// + /// This function does the bare minimum of validation of the offsets and + /// input types. The value_offsets are assumed to be well-formed. + /// + /// \param[in] type_ids An array of 8-bit signed integers, enumerated from + /// 0 corresponding to each type. + /// \param[in] value_offsets An array of signed int32 values indicating the + /// relative offset into the respective child array for the type in a given slot. + /// The respective offsets for each child value array must be in order / increasing. + /// \param[in] children Vector of children Arrays containing the data for each type. + /// \param[out] out Will have length equal to value_offsets.length() + static Status FromDense(const Array& type_ids, const Array& value_offsets, Review comment: Hm, this is naming similar to `ListArray::FromArrays`, but because there are two versions, I wonder if calling this `UnionArray::MakeDense` (or `FromArraysDense`, more verbose) would be clearer ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Add test cases and basic APIs for UnionArray > ----------------------------------------------------- > > Key: ARROW-972 > URL: https://issues.apache.org/jira/browse/ARROW-972 > Project: Apache Arrow > Issue Type: New Feature > Components: Python > Affects Versions: 0.3.0 > Reporter: Wes McKinney > Assignee: Philipp Moritz > Labels: pull-request-available > Fix For: 0.8.0 > > > While this is implemented in C++, there isn't any API exposure yet in Python -- This message was sent by Atlassian JIRA (v6.4.14#64029)