[
https://issues.apache.org/jira/browse/ARROW-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250761#comment-16250761
]
ASF GitHub Bot commented on ARROW-1693:
---------------------------------------
trxcllnt commented on a change in pull request #1294: ARROW-1693: [JS] Fix
reading C++ dictionary-encoded vectors
URL: https://github.com/apache/arrow/pull/1294#discussion_r150728634
##########
File path: js/npm-release.sh
##########
@@ -17,10 +17,7 @@
# specific language governing permissions and limitations
# under the License.
-npm run clean
-npm run lint
-npm run build
-npm run test
-npm --no-git-tag-version version patch &>/dev/null
-npm run bundle
-npm run lerna:publish
\ No newline at end of file
+bump=${1:-patch} && echo "semantic-version bump: $bump"
+
+run-s --silent lint build test
+lerna publish --yes --skip-git --cd-version $bump --force-publish=*
Review comment:
@wesm That makes sense. The way I have things set up, we compile and publish
multiple modules to npm:
- one [large-ish module](https://www.npmjs.com/package/apache-arrow) that
you can get via `npm install apache-arrow`
- the rest as smaller/specialized modules under the
[`@apache-arrow`](https://www.npmjs.com/org/apache-arrow) [npm
organization](https://www.npmjs.com/docs/orgs/), which can be installed via the
formula `npm install @apache-arrow/<target-name>`. For example, `npm install
@apache-arrow/es5-cjs` installs the slimmed down ES5/CommonJS target
The `npm run build` command compiles all the output targets to the
(gitignored) `targets` directory. The `lerna publish --yes --skip-git
--cd-version $bump --force-publish=*` command publishes all the targets to npm.
So from the sound of it, all we need to do is tar up the `targets` directory
with a shell script that installs and runs `lerna publish`, and we're good to
go? If so, I can do that tonight.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JS] Error reading dictionary-encoded integration test files
> ------------------------------------------------------------
>
> Key: ARROW-1693
> URL: https://issues.apache.org/jira/browse/ARROW-1693
> Project: Apache Arrow
> Issue Type: Bug
> Components: JavaScript
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Labels: pull-request-available
> Fix For: 0.8.0
>
> Attachments: dictionary-cpp.arrow, dictionary-java.arrow,
> dictionary.json
>
>
> The JS implementation crashes when reading the dictionary test case from the
> integration tests.
> To replicate, first generate the test files with java and cpp impls:
> {code}
> $ cd ${ARROW_HOME}/integration/
> $ python -c 'from integration_test import generate_dictionary_case;
> generate_dictionary_case().write("dictionary.json")'
> $ ../cpp/debug/debug/json-integration-test --integration
> --json=dictionary.json --arrow=dictionary-cpp.arrow --mode=JSON_TO_ARROW
> $ java -cp
> ../java/tools/target/arrow-tools-0.8.0-SNAPSHOT-jar-with-dependencies.jar
> org.apache.arrow.tools.Integration -c JSON_TO_ARROW -a dictionary-java.arrow
> -j dictionary.json
> {code}
> Attempt to read the files with the JS impl:
> {code}
> $ cd ${ARROW_HOME}/js/
> $ ./bin/arrow2csv.js -s dict1_0 -f ../integration/dictionary-{java,cpp}.arrow
> {code}
> Both files result in an error for me on
> [a8f51858|https://github.com/apache/arrow/commit/a8f518588fda471b2e3cc8e0f0064e7c4bb99899]:
> {{TypeError: Cannot read property 'buffer' of undefined}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
