[
https://issues.apache.org/jira/browse/ARROW-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257609#comment-16257609
]
ASF GitHub Bot commented on ARROW-1827:
---------------------------------------
icexelloss commented on a change in pull request #1326: ARROW-1827: [Java] Add
checkstyle file and license template
URL: https://github.com/apache/arrow/pull/1326#discussion_r151794495
##########
File path: java/checkstyle/checkstyle.xml
##########
@@ -0,0 +1,238 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<!DOCTYPE module PUBLIC
+ "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
+ "http://www.puppycrawl.com/dtds/configuration_1_3.dtd";>
+
+<!--
+ Checkstyle configuration that checks the Google coding conventions from
Google Java Style
+ that can be found at https://google.github.io/styleguide/javaguide.html.
+
+ Checkstyle is very configurable. Be sure to read the documentation at
+ http://checkstyle.sf.net (or in your downloaded distribution).
+
+ To completely disable a check, just comment it out or delete it from the
file.
+
+ Authors: Max Vetrenko, Ruslan Diachenko, Roman Ivanov.
Review comment:
I am actually leaning towards using google_checks.xml if possible. The beam
file seems to be somewhat different of the google checks, which seems to be
more widely used and probably is easier to find an IDE codestyle config for.
Some other ASF project, such as Spark, also seems to be using google checks:
https://github.com/apache/spark/blob/master/dev/checkstyle.xml
@wesm Is it possible to consult with ASF legal?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Java] Add checkstyle config file and header file
> -------------------------------------------------
>
> Key: ARROW-1827
> URL: https://issues.apache.org/jira/browse/ARROW-1827
> Project: Apache Arrow
> Issue Type: Task
> Reporter: Li Jin
> Assignee: Li Jin
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
