[ https://issues.apache.org/jira/browse/ARROW-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257644#comment-16257644 ]
ASF GitHub Bot commented on ARROW-1693: --------------------------------------- wesm commented on issue #1294: ARROW-1693: [JS] Fix reading C++ dictionary-encoded vectors URL: https://github.com/apache/arrow/pull/1294#issuecomment-345377333 Sorry that I missed the thing. I will figure out what's going on here: > Then I had to manually edit the "primitive.json" file to remove the "binary_nullable" and "binary_nonnullable" columns, because the C++ command fails if they're present (click to expand) ``` $ ../cpp/build/release/json-integration-test \ --integration --mode=JSON_TO_ARROW \ --json=./test/arrows/json/primitive.json \ --arrow=./test/arrows/cpp/file/primitive.arrow Found schema: bool_nullable: bool bool_nonnullable: bool not null int8_nullable: int8 int8_nonnullable: int8 not null int16_nullable: int16 int16_nonnullable: int16 not null int32_nullable: int32 int32_nonnullable: int32 not null int64_nullable: int64 int64_nonnullable: int64 not null uint8_nullable: uint8 uint8_nonnullable: uint8 not null uint16_nullable: uint16 uint16_nonnullable: uint16 not null uint32_nullable: uint32 uint32_nonnullable: uint32 not null uint64_nullable: uint64 uint64_nonnullable: uint64 not null float32_nullable: float float32_nonnullable: float not null float64_nullable: double float64_nonnullable: double not null binary_nullable: binary binary_nonnullable: binary not null utf8_nullable: string utf8_nonnullable: string not null Error message: Invalid: Encountered non-hex digit ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [JS] Error reading dictionary-encoded integration test files > ------------------------------------------------------------ > > Key: ARROW-1693 > URL: https://issues.apache.org/jira/browse/ARROW-1693 > Project: Apache Arrow > Issue Type: Bug > Components: JavaScript > Reporter: Brian Hulette > Assignee: Brian Hulette > Labels: pull-request-available > Fix For: 0.8.0 > > Attachments: dictionary-cpp.arrow, dictionary-java.arrow, > dictionary.json > > > The JS implementation crashes when reading the dictionary test case from the > integration tests. > To replicate, first generate the test files with java and cpp impls: > {code} > $ cd ${ARROW_HOME}/integration/ > $ python -c 'from integration_test import generate_dictionary_case; > generate_dictionary_case().write("dictionary.json")' > $ ../cpp/debug/debug/json-integration-test --integration > --json=dictionary.json --arrow=dictionary-cpp.arrow --mode=JSON_TO_ARROW > $ java -cp > ../java/tools/target/arrow-tools-0.8.0-SNAPSHOT-jar-with-dependencies.jar > org.apache.arrow.tools.Integration -c JSON_TO_ARROW -a dictionary-java.arrow > -j dictionary.json > {code} > Attempt to read the files with the JS impl: > {code} > $ cd ${ARROW_HOME}/js/ > $ ./bin/arrow2csv.js -s dict1_0 -f ../integration/dictionary-{java,cpp}.arrow > {code} > Both files result in an error for me on > [a8f51858|https://github.com/apache/arrow/commit/a8f518588fda471b2e3cc8e0f0064e7c4bb99899]: > {{TypeError: Cannot read property 'buffer' of undefined}} -- This message was sent by Atlassian JIRA (v6.4.14#64029)