[
https://issues.apache.org/jira/browse/ARROW-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263281#comment-16263281
]
ASF GitHub Bot commented on ARROW-1577:
---------------------------------------
trxcllnt commented on issue #1346: ARROW-1577: [JS] add ASF release scripts
URL: https://github.com/apache/arrow/pull/1346#issuecomment-346462332
@wesm ah right, I forgot you need the dependencies installed. I've updated
the release script run `npm install` before doing things.
You shouldn't need to hand edit the version in package.json, because the
[`npm version`](https://docs.npmjs.com/cli/version) command will do that for
you
[here](https://github.com/apache/arrow/pull/1346/commits/567c570e3568a97e90349e6911fa342b6c08274b#diff-2ca055280723a1db988255852328f368R54).
If the version is already set in package.json to the value you pass to
`js-source-release.sh`, the command will fail with a "same-version" error.
`npm version` typically also automatically creates git tags. I had this
disabled, but found a config variable that lets us specify the [tag version
prefix](https://docs.npmjs.com/misc/config#tag-version-prefix)
So now [this
command](https://github.com/apache/arrow/pull/1346/commits/6692e1797a355e7351be16cced42511ff2bb006c#diff-2ca055280723a1db988255852328f368R44)
will:
1. increment the package.json version to the `$js_version` you pass to
`js-source-release.sh`
2. `git commit -m "[Release] apache-arrow-js-X.Y.Z"`
3. `git tag -a apache-arrow-js-X.Y.Z` ([specified
here]((https://github.com/apache/arrow/pull/1346/commits/6692e1797a355e7351be16cced42511ff2bb006c#diff-3564d26fe29cca7ef63a785b2ed23ed0R3)))
so now you shouldn't have to explicitly create a new git tag before running
`js-source-release.sh`, as npm will do that automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [JS] Package release script for NPM modules
> -------------------------------------------
>
> Key: ARROW-1577
> URL: https://issues.apache.org/jira/browse/ARROW-1577
> Project: Apache Arrow
> Issue Type: New Feature
> Components: JavaScript
> Affects Versions: 0.8.0
> Reporter: Wes McKinney
> Assignee: Paul Taylor
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> Since the NPM JavaScript module may wish to release more frequently than the
> main Arrow "monorepo", we should create a script to produce signed NPM
> artifacts to use for voting:
> * Update metadata for new version
> * Run unit tests
> * Create package tarballs with NPM
> * GPG sign and create md5 and sha512 checksum files
> * Upload to Apache dev SVN
> i.e. like
> https://github.com/apache/arrow/blob/master/dev/release/02-source.sh, but
> only for JavaScript.
> We will also want to write instructions for Arrow developers to verify the
> tarballs to streamline the release votes
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
