[
https://issues.apache.org/jira/browse/ARROW-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266621#comment-16266621
]
ASF GitHub Bot commented on ARROW-1755:
---------------------------------------
MaxRis commented on a change in pull request #1333: ARROW-1755: [C++] CMake
option to link msvc crt statically
URL: https://github.com/apache/arrow/pull/1333#discussion_r153154771
##########
File path: cpp/build-support/lz4_msbuild_gl_runtimelibrary_params.patch
##########
@@ -0,0 +1,601 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+diff --git a/visual/VS2010/datagen/datagen.vcxproj
b/visual/VS2010/datagen/datagen.vcxproj
+index aaf81ad..096741a 100644
+--- a/visual/VS2010/datagen/datagen.vcxproj
++++ b/visual/VS2010/datagen/datagen.vcxproj
+@@ -39,15 +39,19 @@
+ <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'"
Label="Configuration">
+ <ConfigurationType>Application</ConfigurationType>
+ <UseDebugLibraries>false</UseDebugLibraries>
+- <WholeProgramOptimization>true</WholeProgramOptimization>
+ <CharacterSet>Unicode</CharacterSet>
+ </PropertyGroup>
+ <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'"
Label="Configuration">
+ <ConfigurationType>Application</ConfigurationType>
+ <UseDebugLibraries>false</UseDebugLibraries>
+- <WholeProgramOptimization>true</WholeProgramOptimization>
+ <CharacterSet>Unicode</CharacterSet>
+ </PropertyGroup>
++ <PropertyGroup
Condition="'$(Configuration)|$(Platform)|$(WholeProgramOptimization)'=='Release|Win32|true'"
Label="Configuration">
++ <WholeProgramOptimization>true</WholeProgramOptimization>
++ </PropertyGroup>
++ <PropertyGroup
Condition="'$(Configuration)|$(Platform)|$(WholeProgramOptimization)'=='Release|x64|true'"
Label="Configuration">
++ <WholeProgramOptimization>true</WholeProgramOptimization>
++ </PropertyGroup>
+ <Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />
+ <ImportGroup Label="ExtensionSettings">
+ </ImportGroup>
+@@ -113,6 +117,46 @@
+ <GenerateDebugInformation>true</GenerateDebugInformation>
+ </Link>
+ </ItemDefinitionGroup>
++ <ItemDefinitionGroup
Condition="'$(Configuration)|$(Platform)|$(RuntimeLibrary)'=='Release|Win32|MultiThreaded'"
Label="Configuration">
++ <ClCompile>
++ <RuntimeLibrary>MultiThreaded</RuntimeLibrary>
++ </ClCompile>
++ </ItemDefinitionGroup>
++ <ItemDefinitionGroup
Condition="'$(Configuration)|$(Platform)|$(RuntimeLibrary)'=='Debug|Win32|MultiThreadedDebug'"
Label="Configuration">
++ <ClCompile>
++ <RuntimeLibrary>MultiThreadedDebug</RuntimeLibrary>
++ </ClCompile>
++ </ItemDefinitionGroup>
++ <ItemDefinitionGroup
Condition="'$(Configuration)|$(Platform)|$(RuntimeLibrary)'=='Release|Win32|MultiThreadedDLL'"
Label="Configuration">
++ <ClCompile>
++ <RuntimeLibrary>MultiThreadedDLL</RuntimeLibrary>
++ </ClCompile>
++ </ItemDefinitionGroup>
++ <ItemDefinitionGroup
Condition="'$(Configuration)|$(Platform)|$(RuntimeLibrary)'=='Debug|Win32|MultiThreadedDebugDLL'"
Label="Configuration">
++ <ClCompile>
++ <RuntimeLibrary>MultiThreadedDebugDLL</RuntimeLibrary>
++ </ClCompile>
++ </ItemDefinitionGroup>
++ <ItemDefinitionGroup
Condition="'$(Configuration)|$(Platform)|$(RuntimeLibrary)'=='Release|x64|MultiThreaded'"
Label="Configuration">
++ <ClCompile>
++ <RuntimeLibrary>MultiThreaded</RuntimeLibrary>
++ </ClCompile>
++ </ItemDefinitionGroup>
++ <ItemDefinitionGroup
Condition="'$(Configuration)|$(Platform)|$(RuntimeLibrary)'=='Debug|x64|MultiThreadedDebug'"
Label="Configuration">
++ <ClCompile>
++ <RuntimeLibrary>MultiThreadedDebug</RuntimeLibrary>
++ </ClCompile>
++ </ItemDefinitionGroup>
++ <ItemDefinitionGroup
Condition="'$(Configuration)|$(Platform)|$(RuntimeLibrary)'=='Release|x64|MultiThreadedDLL'"
Label="Configuration">
++ <ClCompile>
++ <RuntimeLibrary>MultiThreadedDLL</RuntimeLibrary>
++ </ClCompile>
++ </ItemDefinitionGroup>
++ <ItemDefinitionGroup
Condition="'$(Configuration)|$(Platform)|$(RuntimeLibrary)'=='Debug|x64|MultiThreadedDebugDLL'"
Label="Configuration">
++ <ClCompile>
++ <RuntimeLibrary>MultiThreadedDebugDLL</RuntimeLibrary>
++ </ClCompile>
++ </ItemDefinitionGroup>
Review comment:
Yes, that was created manually.
New patch solves 2 issues - removing WholeProgramOptimization param and
makes it optional ( that was solved in patch
cpp/build-support/lz4_msbuild_wholeprogramoptimization_param.patch deleted with
this changelist. I can reduce size of patch just to remove
WholeProgramOptimization param completely and do not make it optional, since
we don't use it all. WholeProgramOptimization is default for VS2010, but is not
used in later versions of VS) and setting preffered runtime library (since 4
versions of runtime library exists MD, MDd, MT, MTd, each should be mentioned
in configuration). I believe that changes related to runtime library selection
are necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Add build options for MSVC to use static runtime libraries
> ----------------------------------------------------------------
>
> Key: ARROW-1755
> URL: https://issues.apache.org/jira/browse/ARROW-1755
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Assignee: Max Risuhin
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
