[
https://issues.apache.org/jira/browse/ARROW-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276099#comment-16276099
]
ASF GitHub Bot commented on ARROW-1839:
---------------------------------------
wesm commented on a change in pull request #1335: ARROW-1839/ARROW-1871:
[C++/Python] Add Decimal Parquet Read/Write Tests
URL: https://github.com/apache/arrow/pull/1335#discussion_r154536942
##########
File path: cpp/src/arrow/python/builtin_convert.cc
##########
@@ -390,28 +390,26 @@ class TypedConverterVisitor : public
TypedConverter<BuilderType> {
}
return Status::OK();
}
-
- virtual Status AppendItem(const OwnedRef& item) = 0;
};
class NullConverter : public TypedConverterVisitor<NullBuilder, NullConverter>
{
public:
- inline Status AppendItem(const OwnedRef& item) {
+ Status AppendItem(const OwnedRef& item) {
Review comment:
I'm not sure why these were ever virtual. Making them non-virtual because
we're already using CRTP here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++/Python] Add Decimal Parquet Read/Write Tests
> -------------------------------------------------
>
> Key: ARROW-1839
> URL: https://issues.apache.org/jira/browse/ARROW-1839
> Project: Apache Arrow
> Issue Type: Test
> Components: C++, Python
> Affects Versions: 0.7.1
> Reporter: Phillip Cloud
> Assignee: Phillip Cloud
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
