[
https://issues.apache.org/jira/browse/ARROW-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276421#comment-16276421
]
ASF GitHub Bot commented on ARROW-1864:
---------------------------------------
zsxwing commented on a change in pull request #1376: ARROW-1864: [Java] Upgrade
Netty to 4.1.17
URL: https://github.com/apache/arrow/pull/1376#discussion_r154578316
##########
File path: java/memory/src/main/java/io/netty/buffer/ArrowBuf.java
##########
@@ -493,6 +494,16 @@ public ArrowBuf retain() {
return retain(1);
}
+ @Override
+ public ByteBuf touch() {
+ return this;
Review comment:
The `touch` method is added for
`AdvancedLeakAwareByteBuf/AdvancedLeakAwareCompositeByteBuf`. Other ByteBufs
just need to delegate it or implement it as an empty method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Java] Upgrade Netty to 4.1.x
> -----------------------------
>
> Key: ARROW-1864
> URL: https://issues.apache.org/jira/browse/ARROW-1864
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Java - Memory
> Reporter: Shixiong Zhu
> Assignee: Shixiong Zhu
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> The Netty community will declare Netty 4.0.x as EOL at the beginning of the
> second quarter of 2018: https://github.com/netty/netty/issues/7439
> It would be great that Arrow can migrate to Netty 4.1.x soon. This is the
> only blocker for Spark to migrate to Netty 4.1.x.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
