[
https://issues.apache.org/jira/browse/ARROW-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279051#comment-16279051
]
ASF GitHub Bot commented on ARROW-1491:
---------------------------------------
wesm commented on a change in pull request #1387: ARROW-1491: [C++] Add casting
implementations from strings to numbers or boolean
URL: https://github.com/apache/arrow/pull/1387#discussion_r155044277
##########
File path: cpp/src/arrow/compute/kernels/cast.cc
##########
@@ -17,6 +17,9 @@
#include "arrow/compute/kernels/cast.h"
+#include <boost/algorithm/string.hpp>
+#include <boost/lexical_cast.hpp>
+#include <boost/numeric/conversion/cast.hpp>
Review comment:
Is it possible to not rely on Boost for this, e.g. are there some
alternatives in the STL or that we can access otherwise? I will review the rest
in more detail later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Add casting implementations from strings to numbers or boolean
> --------------------------------------------------------------------
>
> Key: ARROW-1491
> URL: https://issues.apache.org/jira/browse/ARROW-1491
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
> Reporter: Wes McKinney
> Assignee: Licht Takeuchi
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
