[
https://issues.apache.org/jira/browse/ARROW-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293993#comment-16293993
]
ASF GitHub Bot commented on ARROW-1927:
---------------------------------------
robertnishihara commented on a change in pull request #1427: ARROW-1927:
[Plasma] Add delete function
URL: https://github.com/apache/arrow/pull/1427#discussion_r157356806
##########
File path: cpp/src/plasma/client.cc
##########
@@ -501,9 +501,19 @@ Status PlasmaClient::Abort(const ObjectID& object_id) {
}
Status PlasmaClient::Delete(const ObjectID& object_id) {
Review comment:
In `client.h` we should probably clarify the behavior of this method. In
particular, if a client calls `Delete`, that does not guarantee that the object
will be deleted. In particular, if the object is in use by another client, then
the `Delete` call is a no-op, right? Can you mention this in the documentation
for this method in `client.h`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Plasma] Implement delete function
> ----------------------------------
>
> Key: ARROW-1927
> URL: https://issues.apache.org/jira/browse/ARROW-1927
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Plasma (C++), Python
> Reporter: Philipp Moritz
> Labels: pull-request-available
>
> The function should check if the reference count of the object is zero and if
> yes, delete it from the store. If no, it should raise an exception or return
> a status value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
