[
https://issues.apache.org/jira/browse/ARROW-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332611#comment-16332611
]
ASF GitHub Bot commented on ARROW-1712:
---------------------------------------
wesm commented on a change in pull request #1481: ARROW-1712: [C++] Add method
to BinaryBuilder to reserve space for value data
URL: https://github.com/apache/arrow/pull/1481#discussion_r162685815
##########
File path: cpp/src/arrow/builder.cc
##########
@@ -1208,7 +1208,7 @@ ArrayBuilder* ListBuilder::value_builder() const {
// String and binary
BinaryBuilder::BinaryBuilder(const std::shared_ptr<DataType>& type,
MemoryPool* pool)
- : ArrayBuilder(type, pool), offsets_builder_(pool),
value_data_builder_(pool) {}
+ : ArrayBuilder(type, pool), offsets_builder_(pool),
value_data_builder_(pool), data_capacity_(0) {}
Review comment:
I don't think we need this extra member; we can just use
`value_data_capacity()` wherever `data_capacity_` is currently being used
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Add method to BinaryBuilder to reserve space for value data
> -----------------------------------------------------------------
>
> Key: ARROW-1712
> URL: https://issues.apache.org/jira/browse/ARROW-1712
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Assignee: Panchen Xue
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> The {{Resize}} and {{Reserve}} methods only reserve space for the value
> offsets. When building binary/string arrays with a known size (or some
> reasonable estimate), it would be more efficient to reserve once at the
> beginning to prevent internal reallocations
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
