[
https://issues.apache.org/jira/browse/ARROW-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355978#comment-16355978
]
ASF GitHub Bot commented on ARROW-2111:
---------------------------------------
wesm closed pull request #1573: ARROW-2111: [C++] Lint in parallel
URL: https://github.com/apache/arrow/pull/1573
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
index 073471283..62c8e6590 100644
--- a/cpp/CMakeLists.txt
+++ b/cpp/CMakeLists.txt
@@ -455,11 +455,14 @@ if (UNIX)
message(STATUS "Found cpplint executable at ${CPPLINT_BIN}")
# Full lint
- add_custom_target(lint ${CPPLINT_BIN}
+ # Balancing act: cpplint.py takes a non-trivial time to launch,
+ # so process 12 files per invocation, while still ensuring parallelism
+ add_custom_target(lint echo ${FILTERED_LINT_FILES} | xargs -n12 -P8
+ ${CPPLINT_BIN}
--verbose=2
--linelength=90
--filter=-whitespace/comments,-readability/todo,-build/header_guard,-build/c++11,-runtime/references,-build/include_order
- ${FILTERED_LINT_FILES})
+ )
endif (UNIX)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Linting could be faster
> -----------------------------
>
> Key: ARROW-2111
> URL: https://issues.apache.org/jira/browse/ARROW-2111
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Affects Versions: 0.8.0
> Reporter: Antoine Pitrou
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> Currently {{make lint}} style-checks C++ files sequentially (by calling
> {{cpplint}}). We could instead style-check those files in parallel.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
