[
https://issues.apache.org/jira/browse/ARROW-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357810#comment-16357810
]
ASF GitHub Bot commented on ARROW-1579:
---------------------------------------
BryanCutler commented on a change in pull request #1319: [WIP] ARROW-1579:
[Java] Adding containerized Spark Integration tests
URL: https://github.com/apache/arrow/pull/1319#discussion_r167120268
##########
File path: python/pyarrow/__init__.py
##########
@@ -24,7 +24,7 @@
# package is not installed
try:
import setuptools_scm
- __version__ = setuptools_scm.get_version('../')
+ __version__ = setuptools_scm.get_version(root='../../',
relative_to=__file__)
Review comment:
@xhochy and @wesm , I needed to change this because it would only give a
version if run under ARROW_HOME/python directory. So when running Spark tests,
on importing pyarrow it would return `None`. Making it relative to the
`__file__` seemed to fix it for all cases. I can make this a separate JIRA if
you think that would be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Java] Add dockerized test setup to validate Spark integration
> --------------------------------------------------------------
>
> Key: ARROW-1579
> URL: https://issues.apache.org/jira/browse/ARROW-1579
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Java - Vectors
> Reporter: Wes McKinney
> Assignee: Bryan Cutler
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> cc [~bryanc] -- the goal of this will be to validate master-to-master to
> catch any regressions in the Spark integration
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
