[
https://issues.apache.org/jira/browse/ARROW-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360827#comment-16360827
]
ASF GitHub Bot commented on ARROW-2134:
---------------------------------------
wesm closed pull request #1590: ARROW-2134: [CI] Make Travis-CI commit
inspection more robust
URL: https://github.com/apache/arrow/pull/1590
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ci/travis_detect_changes.py b/ci/travis_detect_changes.py
index 284261903..2aeb34fa0 100644
--- a/ci/travis_detect_changes.py
+++ b/ci/travis_detect_changes.py
@@ -70,6 +70,13 @@ def get_travis_commit_range():
return cr.replace('...', '..')
+def get_travis_commit_description():
+ # Prefer this to get_commit_description(get_travis_head_commit()),
+ # as rebasing or other repository events may make TRAVIS_COMMIT invalid
+ # at the time we inspect it
+ return os.environ['TRAVIS_COMMIT_MESSAGE']
+
+
def list_travis_affected_files():
"""
Return a list of files affected in the current Travis build.
@@ -140,7 +147,7 @@ def get_unix_shell_eval(env):
def run_from_travis():
- desc = get_commit_description(get_travis_head_commit())
+ desc = get_travis_commit_description()
if '[skip travis]' in desc:
# Skip everything
affected = dict.fromkeys(ALL_TOPICS, False)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [CI] Make Travis commit inspection more robust
> ----------------------------------------------
>
> Key: ARROW-2134
> URL: https://issues.apache.org/jira/browse/ARROW-2134
> Project: Apache Arrow
> Issue Type: Task
> Components: Continuous Integration
> Reporter: Antoine Pitrou
> Assignee: Antoine Pitrou
> Priority: Minor
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> See [https://github.com/apache/arrow/pull/1586#issuecomment-364857558]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
