[
https://issues.apache.org/jira/browse/ARROW-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361447#comment-16361447
]
ASF GitHub Bot commented on ARROW-2138:
---------------------------------------
wesm commented on issue #1595: ARROW-2138: [C++] abort on failed debug check
URL: https://github.com/apache/arrow/pull/1595#issuecomment-365062726
OK, the Windows builds look fine. I'm merging this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Have FatalLog abort instead of exiting
> --------------------------------------------
>
> Key: ARROW-2138
> URL: https://issues.apache.org/jira/browse/ARROW-2138
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Antoine Pitrou
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> Not sure this is desirable, since {{util/logging.h}} was taken from glog, but
> the various debug checks current {{std::exit(1)}} on failure. This is a clean
> exit (though with an error code) and therefore doesn't trigger the usual
> debugging tools such as gdb or Python's faulthandler. By replacing it with
> something like {{std::abort()}} the exit would be recognized as a process
> crash.
>
> Thoughts?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
