[
https://issues.apache.org/jira/browse/ARROW-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373598#comment-16373598
]
ASF GitHub Bot commented on ARROW-2199:
---------------------------------------
vkorukanti commented on a change in pull request #1646: ARROW-2199: [JAVA]
Control the memory allocated for inner vectors in containers.
URL: https://github.com/apache/arrow/pull/1646#discussion_r170115978
##########
File path:
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueVector.java
##########
@@ -166,13 +168,23 @@ public void setInitialCapacity(int numRecords) {
* This helps in tightly controlling the memory we provision
* for inner data vector.
*/
+ @Override
public void setInitialCapacity(int numRecords, double density) {
+ if ((numRecords * density) >= 2_000_000_000) {
Review comment:
why are we using a different constant here than MAX_ALLOCATION_SIZE?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [JAVA] Follow up fixes for ARROW-2019. Ensure density driven capacity is
> never less than 1 and propagate density throughout the vector tree
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ARROW-2199
> URL: https://issues.apache.org/jira/browse/ARROW-2199
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Java - Vectors
> Reporter: Siddharth Teotia
> Assignee: Siddharth Teotia
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
