[
https://issues.apache.org/jira/browse/ARROW-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380838#comment-16380838
]
ASF GitHub Bot commented on ARROW-2230:
---------------------------------------
wesm closed pull request #1676: ARROW-2230: [Python] Strip catch-all tag
matching from git-describe
URL: https://github.com/apache/arrow/pull/1676
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/python/setup.py b/python/setup.py
index 849d1203b..2a6326489 100644
--- a/python/setup.py
+++ b/python/setup.py
@@ -422,6 +422,8 @@ def parse_version(root):
from setuptools_scm import version_from_scm
import setuptools_scm.git
describe = setuptools_scm.git.DEFAULT_DESCRIBE + " --match
'apache-arrow-[0-9]*'"
+ # Strip catchall from the commandline
+ describe = describe.replace("--match *.*", "")
version = setuptools_scm.git.parse(root, describe)
if not version:
return version_from_scm(root)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Python] JS version number is sometimes picked up
> -------------------------------------------------
>
> Key: ARROW-2230
> URL: https://issues.apache.org/jira/browse/ARROW-2230
> Project: Apache Arrow
> Issue Type: Bug
> Components: Python
> Reporter: Uwe L. Korn
> Assignee: Uwe L. Korn
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> Depending on the installed git version, command line arguments are parsed
> differently. Thus in some cases we pick up the non-JS tag, in other cases
> simply the latest one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
