[
https://issues.apache.org/jira/browse/ARROW-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393007#comment-16393007
]
ASF GitHub Bot commented on ARROW-2250:
---------------------------------------
wesm closed pull request #1705: ARROW-2250: [Python] Do not create a subprocess
for plasma but just use existing process
URL: https://github.com/apache/arrow/pull/1705
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/python/pyarrow/__init__.py b/python/pyarrow/__init__.py
index 15a37ca10..2afa6c150 100644
--- a/python/pyarrow/__init__.py
+++ b/python/pyarrow/__init__.py
@@ -142,11 +142,9 @@ def _plasma_store_entry_point():
"""
import os
import pyarrow
- import subprocess
import sys
plasma_store_executable = os.path.join(pyarrow.__path__[0], "plasma_store")
- process = subprocess.Popen([plasma_store_executable] + sys.argv[1:])
- process.wait()
+ os.execv(plasma_store_executable, sys.argv)
# ----------------------------------------------------------------------
# Deprecations
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> plasma_store process should cleanup on INT and TERM signals
> -----------------------------------------------------------
>
> Key: ARROW-2250
> URL: https://issues.apache.org/jira/browse/ARROW-2250
> Project: Apache Arrow
> Issue Type: Improvement
> Affects Versions: 0.8.0
> Reporter: Mitar
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> Currently, if you send an INT and TERM signal to a parent plasma store
> process (Python one) it terminates it without cleaning the child process.
> This makes it hard to run plasma store in non-interactive mode. Inside shell
> ctrl-c kills both processes.
> Moreover, INT prints out an ugly KeyboardInterrup exception. Probably
> something nicer should be done.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
