[
https://issues.apache.org/jira/browse/ARROW-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393590#comment-16393590
]
ASF GitHub Bot commented on ARROW-2099:
---------------------------------------
wesm commented on a change in pull request #1734: ARROW-2099: [Python] Add safe
option to DictionaryArray.from_arrays to do boundschecking of indices by default
URL: https://github.com/apache/arrow/pull/1734#discussion_r173567908
##########
File path: python/setup.py
##########
@@ -208,8 +207,10 @@ def _run_cmake(self):
cmake_options.append('-DCMAKE_BUILD_TYPE={0}'
.format(self.build_type.lower()))
- cmake_options.append('-DBoost_NAMESPACE={}'.format(
- self.boost_namespace))
+
+ if self.boost_namespace is not None:
+ cmake_options.append('-DBoost_NAMESPACE={}'
+ .format(self.boost_namespace))
Review comment:
I added this to prevent a CMake warning when Boost isn't being bundled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Python] Support DictionaryArray::FromArrays in Python bindings
> ---------------------------------------------------------------
>
> Key: ARROW-2099
> URL: https://issues.apache.org/jira/browse/ARROW-2099
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Python
> Reporter: Wes McKinney
> Assignee: Wes McKinney
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> Follow up work from ARROW-1757.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
