[
https://issues.apache.org/jira/browse/ARROW-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411353#comment-16411353
]
ASF GitHub Bot commented on ARROW-2346:
---------------------------------------
xhochy closed pull request #1783: ARROW-2346: [Python] Fix PYARROW_CXX_FLAGS
with multiple options
URL: https://github.com/apache/arrow/pull/1783
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/python/setup.py b/python/setup.py
index cf44b1e43..472469053 100644
--- a/python/setup.py
+++ b/python/setup.py
@@ -190,7 +190,7 @@ def _run_cmake(self):
cmake_options.append('-DPYARROW_BUILD_ORC=on')
if len(self.cmake_cxxflags) > 0:
- cmake_options.append('-DPYARROW_CXXFLAGS="{0}"'
+ cmake_options.append('-DPYARROW_CXXFLAGS={0}'
.format(self.cmake_cxxflags))
if self.bundle_arrow_cpp:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Python] PYARROW_CXXFLAGS doesn't accept multiple options
> ---------------------------------------------------------
>
> Key: ARROW-2346
> URL: https://issues.apache.org/jira/browse/ARROW-2346
> Project: Apache Arrow
> Issue Type: Bug
> Components: Python
> Affects Versions: 0.9.0
> Reporter: Antoine Pitrou
> Priority: Major
> Labels: pull-request-available
>
> Let's say I want to enable multiple warnings. I try:
> {code:bash}
> PYARROW_CXXFLAGS="-Wextra -Wconversion" python setup.py build
> {code}
> and get the following error:
> {code:bash}
> [ 22%] Building CXX object CMakeFiles/plasma.dir/plasma.cxx.o
> g++-4.9: error: unrecognized command line option '-Wextra -Wconversion'
> {code}
> For some reason it seems command expansion doesn't work properly. "{{-Wextra
> -Wconversion}}" is passed as a single argument instead of two separate ones...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
