[ https://issues.apache.org/jira/browse/ARROW-2356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415718#comment-16415718 ]
ASF GitHub Bot commented on ARROW-2356: --------------------------------------- TheNeuralBit commented on issue #1796: ARROW-2356: [JS] Fix JSON Reader FixedSizeBinary Vectors URL: https://github.com/apache/arrow/pull/1796#issuecomment-376547752 This looks good to me, CI failure seems unrelated. Created https://github.com/apache/arrow/pull/1799 to make sure that the fix to integration.js will actually cause a CI failure when it should. Will merge once that's finished. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [JS] JSON reader fails on FixedSizeBinary data buffer > ----------------------------------------------------- > > Key: ARROW-2356 > URL: https://issues.apache.org/jira/browse/ARROW-2356 > Project: Apache Arrow > Issue Type: Bug > Components: JavaScript > Affects Versions: JS-0.3.1 > Reporter: Paul Taylor > Assignee: Paul Taylor > Priority: Major > Labels: pull-request-available > Fix For: JS-0.4.0 > > > The JSON reader doesn't ingest the FixedSizeBinary data buffer correctly, and > we haven't known about it because the JS integration test runner is > accidentally exiting with code 0 on failures. -- This message was sent by Atlassian JIRA (v7.6.3#76005)