[ 
https://issues.apache.org/jira/browse/ARROW-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16419737#comment-16419737
 ] 

Venki Korukanti commented on ARROW-2368:
----------------------------------------

Yes, 
[here|https://github.com/vkorukanti/arrow/commit/a14b263ed442a4a088b1b0e5578993644147a599]
 is the patch. Its on a older version of arrow. Will post once I rebase the 
patch.

> DecimalVector#setBigEndian is not padding correctly for negative values
> -----------------------------------------------------------------------
>
>                 Key: ARROW-2368
>                 URL: https://issues.apache.org/jira/browse/ARROW-2368
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Java - Vectors
>            Reporter: Venki Korukanti
>            Assignee: Venki Korukanti
>            Priority: Blocker
>
> If the input given is less than 16 bytes, we pad zero for the remaining bytes 
> [1]. This is not correct if the value is a negative number. We should pad 
> 0x00 or 0xFF depending upon the number is a positive or negative number. 
> Later when the value is retrieved we end up with an incorrect value.
>  
> [1] 
> https://github.com/apache/arrow/blob/master/java/vector/src/main/java/org/apache/arrow/vector/DecimalVector.java#L231



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to