[ https://issues.apache.org/jira/browse/ARROW-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421821#comment-16421821 ]
ASF GitHub Bot commented on ARROW-1325: --------------------------------------- wesm commented on a change in pull request #1815: ARROW-1325: [R] Bootstrapping R bindings subproject URL: https://github.com/apache/arrow/pull/1815#discussion_r178469306 ########## File path: r/src/metadata.cpp ########## @@ -0,0 +1,215 @@ +#include <Rcpp.h> +#include "rrrow_types.h" + +// [[Rcpp::plugins(cpp11)]] + +using namespace Rcpp ; + +template <typename... String > +xptr_DataType metadata( const std::shared_ptr<arrow::DataType>& ptr, String... strings ){ + xptr_DataType res( new std::shared_ptr<arrow::DataType>(ptr) ) ; + res.attr("class") = CharacterVector::create( ptr->name(), strings... ) ; + return res ; +} + +xptr_DataType metadata_integer( const std::shared_ptr<arrow::DataType>& ptr ){ + return metadata( ptr, "arrow::Integer", "arrow::Number", "arrow::PrimitiveCType", "arrow::FixedWidthType", "arrow::DataType" ) ; Review comment: See https://github.com/apache/arrow/blob/master/cpp/.clang-format. These files do not conform to the C++ code formatting used in the rest of the project ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [R] Bootstrap R bindings subproject > ----------------------------------- > > Key: ARROW-1325 > URL: https://issues.apache.org/jira/browse/ARROW-1325 > Project: Apache Arrow > Issue Type: New Feature > Components: R > Reporter: Clark Fitzgerald > Assignee: Romain François > Priority: Major > Labels: pull-request-available > Fix For: 0.10.0 > > > The R language was designed to perform "Columnar in memory analytics". R / > Arrow bindings would be useful for: > * better compatibility between R and other languages / big data systems > * chunk-based data parallelism > * portable and efficient IO via Parquet > R has a C++ interface so the natural way to write these bindings is to > leverage Arrow's C++ library as much as possible. > Feather provides a starting point: > [https://github.com/wesm/feather/tree/master/R]. > This can serve as an umbrella JIRA for work on R related tasks. -- This message was sent by Atlassian JIRA (v7.6.3#76005)