[
https://issues.apache.org/jira/browse/ARROW-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447828#comment-16447828
]
ASF GitHub Bot commented on ARROW-2494:
---------------------------------------
pitrou commented on a change in pull request #1932: ARROW-2494: [C++] Return
status codes from PlasmaClient::Seal instead of crashing
URL: https://github.com/apache/arrow/pull/1932#discussion_r183327738
##########
File path: cpp/src/plasma/test/client_tests.cc
##########
@@ -90,6 +90,21 @@ class TestPlasmaStore : public ::testing::Test {
PlasmaClient client2_;
};
+TEST_F(TestPlasmaStore, SealErrorsTest) {
+ ObjectID object_id = ObjectID::from_random();
+
+ Status result = client_.Seal(object_id);
+ ASSERT_EQ(result.IsPlasmaObjectNonexistent(), true);
+
+ // Create object.
+ std::vector<uint8_t> data(100, 0);
+ CreateObject(client_, object_id, {42}, data);
+
+ // Trying to seal it again.
+ result = client_.Seal(object_id);
+ ASSERT_EQ(result.IsPlasmaObjectAlreadySealed(), true);
Review comment:
Same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Return status codes from PlasmaClient::Seal
> -------------------------------------------
>
> Key: ARROW-2494
> URL: https://issues.apache.org/jira/browse/ARROW-2494
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: C++
> Reporter: Krisztian Szucs
> Assignee: Krisztian Szucs
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
