[ 
https://issues.apache.org/jira/browse/ARROW-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864416#comment-16864416
 ] 

Wes McKinney commented on ARROW-5474:
-------------------------------------

This is a new one on me... it seems gcc 5.4.0 is pickier about string literals

{code}
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:543:9: error: missing terminating 
" character [-Werror]
   ASSERT_OK(ArrayFromJSON(type, R"delim(
         ^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:543:2: error: missing terminating 
" character
   ASSERT_OK(ArrayFromJSON(type, R"delim(
  ^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:550:1: error: stray '\' in program
 )delim",
 ^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:617:9: error: missing terminating 
" character [-Werror]
   ASSERT_OK(ArrayFromJSON(type, R"delim(
         ^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:617:2: error: missing terminating 
" character
   ASSERT_OK(ArrayFromJSON(type, R"delim(
  ^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:622:9: error: stray '\' in program
         [null, "empty"]
         ^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:622:17: error: missing terminating 
" character [-Werror]
         [null, "empty"]
                 ^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:622:9: error: missing terminating 
" character
         [null, "empty"]
         ^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:630:9: error: stray '\' in program
         ["bootstrapping tautology?", "lispy", null, "i can see eternity"]
         ^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:630:11: error: missing terminating 
" character [-Werror]
         ["bootstrapping tautology?", "lispy", null, "i can see eternity"]
           ^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:630:9: error: missing terminating 
" character
         ["bootstrapping tautology?", "lispy", null, "i can see eternity"]
         ^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:635:1: error: stray '\' in program
 )delim",
 ^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc: In member function 'virtual void 
arrow::ipc::internal::json::TestMap_IntegerToInteger_Test::TestBody()':
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:544:1: error: two consecutive '[' 
shall only introduce an attribute before '[' token
 [
 ^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:544:1: error: return-statement 
with a value, in function returning 'void' [-fpermissive]
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:544:1: error: expected ';' before 
'[' token
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:545:6: error: expected ']' before 
'[' token
     [[0, 1], [1, 1], [2, 2], [3, 3], [4, 5], [5, 8]],
      ^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc: In member function 'virtual void 
arrow::ipc::internal::json::TestMap_IntegerMapToStringList_Test::TestBody()':
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:618:1: error: two consecutive '[' 
shall only introduce an attribute before '[' token
 [
 ^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:618:1: error: return-statement 
with a value, in function returning 'void' [-fpermissive]
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:618:1: error: expected ';' before 
'[' token
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:620:7: error: expected ']' before 
'[' token
       [
{code}

> [C++] What version of Boost do we require now?
> ----------------------------------------------
>
>                 Key: ARROW-5474
>                 URL: https://issues.apache.org/jira/browse/ARROW-5474
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Neal Richardson
>            Assignee: Wes McKinney
>            Priority: Major
>             Fix For: 0.14.0
>
>
> See debugging on https://issues.apache.org/jira/browse/ARROW-5470. One 
> possible cause for that error is that the local filesystem patch increased 
> the version of boost that we actually require. The boost version (1.54 vs 
> 1.58) was one difference between failure and success. 
> Another point of confusion was that CMake reported two different versions of 
> boost at different times. 
> If we require a minimum version of boost, can we document that better, check 
> for it more accurately in the build scripts, and fail with a useful message 
> if that minimum isn't met? Or something else helpful.
> If the actual cause of the failure was something else (e.g. compiler 
> version), we should figure that out too.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to