Kenta Murata created ARROW-5754: ----------------------------------- Summary: [C++]Missing override for ~GrpcStreamWriter? Key: ARROW-5754 URL: https://issues.apache.org/jira/browse/ARROW-5754 Project: Apache Arrow Issue Type: Improvement Components: C++ Reporter: Kenta Murata
I encountered the following compile error: {{../src/arrow/flight/client.cc:244:3: error: '~GrpcStreamWriter' overrides a destructor but is not marked 'override' [-Werror,-Winconsistent-missing-destructor-override] ~GrpcStreamWriter() = default; ^ ../src/arrow/flight/client.h:86:27: note: overridden virtual function is here class ARROW_FLIGHT_EXPORT FlightStreamWriter : public ipc::RecordBatchWriter { ^}} Putting override modifier can resolve this problem. I'll make a pull-request for the change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)