[ 
https://issues.apache.org/jira/browse/ARROW-7026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16966597#comment-16966597
 ] 

Ji Liu commented on ARROW-7026:
-------------------------------

Besides, some assertions are in the hot path(i.e. {{VarCharVector}} set and get 
API), for those usages, should we use Preconditions or just ignore them to 
avoid potential performance regression?

> [Java] Remove assertions in MessageSerializer/vector/writer/reader
> ------------------------------------------------------------------
>
>                 Key: ARROW-7026
>                 URL: https://issues.apache.org/jira/browse/ARROW-7026
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Java
>            Reporter: Ji Liu
>            Assignee: Ji Liu
>            Priority: Major
>
> Currently assertions exists in many classes like 
> {{MessagaSerializer/JsonReader/JsonWriter/ListVector}} etc.
> i. If jvm arguments are not specified, these checks will skipped and lead to 
> potential problems.
> ii. Java errors produced by failed assertions are not caught by traditional 
> catch clauses.
> To fix this, use {{Preconditions}} instead.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to