[ 
https://issues.apache.org/jira/browse/ARROW-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091987#comment-17091987
 ] 

Zachary Gramana edited comment on ARROW-5708 at 4/25/20, 12:37 AM:
-------------------------------------------------------------------

In implementing ARROW-6603, I discovered that I hadn't added a `AppendNull` 
BooleanArray.Builder yet because there were not any BooleanArray.Builder tests 
in "ArrayBuilderTests.cs" to begin with-–nor were there any tests for 
`BooleanArray.Slice` there or in "BooleanArrayTests.cs".

As a result of adding those tests, and getting them to pass, [GitHub PR 
7032|https://github.com/apache/arrow/pull/7032] also now resolves this issue.


was (Author: gramana):
In implementing ARROW-6603, I discovered that I hadn't added a `AppendNull` 
BooleanArray.Builder yet because there were not any BooleanArray.Builder tests 
in "ArrayBuilderTests.cs" to begin with-–nor were there any tests for 
`BooleanArray.Slice` there or in "BooleanArrayTests.cs".

As a result of adding those tests, and getting them to pass, [GitHub PR 
6161|https://github.com/apache/arrow/pull/6121] also now resolves this issue.

> [C#] Null support for BooleanArray
> ----------------------------------
>
>                 Key: ARROW-5708
>                 URL: https://issues.apache.org/jira/browse/ARROW-5708
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C#
>            Reporter: Eric Erhardt
>            Priority: Major
>
> See the conversation 
> [here|https://github.com/apache/arrow/pull/4640#discussion_r296417726] and 
> [here|https://github.com/apache/arrow/pull/3574#discussion_r262662083].
> We should add null support for BooleanArray.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to