pitrou commented on pull request #59:
URL: https://github.com/apache/arrow-testing/pull/59#issuecomment-796768922


   Indeed, the JSON format doesn't support it, so that will be a problem if we 
want to do roundtripping tests with the integration machinery.
   However, I think we can still use the "golden files" part of integration 
testing, because there the logic for each implementation is (see 
[here](https://github.com/apache/arrow/blob/master/cpp/src/arrow/testing/json_integration_test.cc#L225-L234)
 for the C++ implementation):
   * read the JSON file and convert it into a series of record batches
   * read the Arrow file and decode it into a series of record batches
   * compare respective record batches for equality
   
   Comparing for equality doesn't care if the dictionaries are shared, so this 
should be ok for testing the ability to read IPC files with shared dictionaries.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to