[ 
https://issues.apache.org/jira/browse/AURORA-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Sirois reassigned AURORA-1570:
-----------------------------------

    Assignee: John Sirois

> TaskObserverTest::test_run_loop is flaky
> ----------------------------------------
>
>                 Key: AURORA-1570
>                 URL: https://issues.apache.org/jira/browse/AURORA-1570
>             Project: Aurora
>          Issue Type: Bug
>          Components: Observer, Testing
>            Reporter: John Sirois
>            Assignee: John Sirois
>
> As seen in https://reviews.apache.org/r/41897/
> {noformat}
> Master (8706a78) is red with this patch.
>   ./build-support/jenkins/build.sh
>                      
> src/test/python/apache/thermos/observer/test_detector.py::test_observer_task_detector_standard_transitions
>  PASSED
>                      
> src/test/python/apache/thermos/observer/test_detector.py::test_observer_task_detector_nonstandard_transitions
>  PASSED
>                      
> src/test/python/apache/thermos/observer/test_task_observer.py::TaskObserverTest::test_run_loop
>  FAILED
>                      
>                      ==================== FAILURES ====================
>                      _________ TaskObserverTest.test_run_loop _________
>                      
>                      self = <test_task_observer.TaskObserverTest 
> testMethod=test_run_loop>
>                      
>                          def test_run_loop(self):
>                            """Test observer run loop."""
>                            mock_task_detector = 
> create_autospec(spec=ObserverTaskDetector)
>                            with patch(
>                                
> "apache.thermos.observer.task_observer.ObserverTaskDetector",
>                                return_value=mock_task_detector) as 
> mock_detector:
>                              with patch('threading._Event.wait') as 
> mock_wait:
>                          
>                                run_count = 3
>                                interval = 15
>                                observer = TaskObserver(mock_detector, 
> interval=Amount(interval, Time.SECONDS))
>                                observer.start()
>                                while len(mock_wait.mock_calls) < 
> run_count:
>                                  pass
>                          
>                                observer.stop()
>                          
>                      >         assert len(mock_task_detector.mock_calls) 
> >= run_count
>                      E         AssertionError: assert 1 >= 3
>                      E          +  where 1 = 
> len([call.refresh()])
>                      E          +    where [call.refresh()] = 
> <MagicMock spec='ObserverTaskDetector' id='140389955602192'>.mock_calls
>                      
>                      
> src/test/python/apache/thermos/observer/test_task_observer.py:42: 
> AssertionError
>                       generated xml file: 
> /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.thermos.observer.observer.xml
>  
>                      ======= 1 failed, 3 passed in 0.25 seconds 
> =======
>                      
> FAILURE
> 23:20:37 04:05   [complete]
>                FAILURE
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to