[ 
https://issues.apache.org/jira/browse/AURORA-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396591#comment-15396591
 ] 

Mehrdad Nurolahzade commented on AURORA-1741:
---------------------------------------------

Re-opened review board for new test cases added as per [~joshua.cohen] 
recommendation.

> Fix pystachio binding bug introduced by AURORA-1710
> ---------------------------------------------------
>
>                 Key: AURORA-1741
>                 URL: https://issues.apache.org/jira/browse/AURORA-1741
>             Project: Aurora
>          Issue Type: Bug
>          Components: Client
>            Reporter: Mehrdad Nurolahzade
>            Assignee: Mehrdad Nurolahzade
>            Priority: Minor
>
> As part of [AURORA-1710] a warning message was added to the client toolset 
> that warns users about the use of the {{production}} flag.
> {code}
> def _validate_deprecated_config(config):
>   task = config.job().taskConfig
>   if task.production and task.tier is None:
>     deprecation_warning(PRODUCTION_DEPRECATED_WARNING)
> {code}
> This logic can potentially fail if configuration contains unbound bindings at 
> this point. We could simply rely on the raw configuration for this:
> {code}
> def _validate_deprecated_config(config):
>   if config.raw().production().get() and config.raw().tier() is Empty:
>     deprecation_warning(PRODUCTION_DEPRECATED_WARNING)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to