[
https://issues.apache.org/jira/browse/AURORA-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549442#comment-15549442
]
Joshua Cohen commented on AURORA-1787:
--------------------------------------
Sorry, I skimmed over your full patch in the description and mostly answered
the question based on our discussion in Slack last night.
The problem with the patch in the description is that the executor mounts
volumes into the taskfs relative to the root of the filesystem, not relative to
the sandbox. So when you change {{run-server.sh}} to look for
{{./rsyslog.d.container}}, it's doing so relative to {{CWD}} which is
{{/mnt/mesos/sandbox}}. If you look for {{/rsyslog.d.container}} it should work:
{noformat}
vagrant@aurora:~/util-linux-2.24.1$ sudo ./nsenter -m -t 13236
root@aurora:/# ls
bin boot dev etc home lib lib64 media mnt opt proc root
rsyslog.d.container run sbin srv sys tmp usr var
{noformat}
For what it's worth, if you look at the executor's logs you can also see
exactly what it's doing with regards to mounting:
{noformat}
I1005 17:21:26.493562 13110 sandbox.py:282] Mounting rsyslog.d.container into
task filesystem at
/var/lib/mesos/slaves/54325286-97a6-41f3-b0ba-991cf1f733be-S0/frameworks/54325286-97a6-41f3-b0ba-991cf1f733be-0000/executors/thermos-vagrant-test-http_example_unified_docker-0-e1517a6c-1a48-46d0-9fc8-fdcf4d4caf75/runs/1bd5b092-d6a5-4993-a93f-03da7665b1da/taskfs/rsyslog.d.container.
{noformat}
> `-global_container_mounts` does not appear to work with the unified
> containerizer
> ---------------------------------------------------------------------------------
>
> Key: AURORA-1787
> URL: https://issues.apache.org/jira/browse/AURORA-1787
> Project: Aurora
> Issue Type: Bug
> Reporter: Zameer Manji
> Priority: Critical
>
> Perhaps I misunderstand how this feature is supposed to be used, but apply
> the following patch to master:
> {noformat}
> From 1ebb5f4c5815c647e31f3253d5e5c316a0d5edd2 Mon Sep 17 00:00:00 2001
> From: Zameer Manji <zma...@apache.org>
> Date: Tue, 4 Oct 2016 20:45:41 -0700
> Subject: [PATCH] Reproduce the issue.
> ---
> examples/vagrant/upstart/aurora-scheduler.conf | 2 +-
> src/test/sh/org/apache/aurora/e2e/run-server.sh | 4 ++++
> .../sh/org/apache/aurora/e2e/test_end_to_end.sh | 26
> +++++++++++-----------
> 3 files changed, 18 insertions(+), 14 deletions(-)
> diff --git a/examples/vagrant/upstart/aurora-scheduler.conf
> b/examples/vagrant/upstart/aurora-scheduler.conf
> index 91b27d7..851b5a1 100644
> --- a/examples/vagrant/upstart/aurora-scheduler.conf
> +++ b/examples/vagrant/upstart/aurora-scheduler.conf
> @@ -40,7 +40,7 @@ exec bin/aurora-scheduler \
> -native_log_file_path=/var/db/aurora \
> -backup_dir=/var/lib/aurora/backups \
> -thermos_executor_path=$DIST_DIR/thermos_executor.pex \
> -
> -global_container_mounts=/home/vagrant/aurora/examples/vagrant/config:/home/vagrant/aurora/examples/vagrant/config:ro
> \
> + -global_container_mounts=/etc/rsyslog.d:rsyslog.d.container:ro \
> -thermos_executor_flags="--announcer-ensemble localhost:2181
> --announcer-zookeeper-auth-config
> /home/vagrant/aurora/examples/vagrant/config/announcer-auth.json
> --mesos-containerizer-path=/usr/libexec/mesos/mesos-containerizer" \
> -allowed_container_types=MESOS,DOCKER \
> -http_authentication_mechanism=BASIC \
> diff --git a/src/test/sh/org/apache/aurora/e2e/run-server.sh
> b/src/test/sh/org/apache/aurora/e2e/run-server.sh
> index 1fe0909..a0ee76f 100755
> --- a/src/test/sh/org/apache/aurora/e2e/run-server.sh
> +++ b/src/test/sh/org/apache/aurora/e2e/run-server.sh
> @@ -1,6 +1,10 @@
> #!/bin/bash
>
> echo "Starting up server..."
> +if [ ! -d "./rsyslog.d.container" ]; then
> + echo "Mountpoint Doesn't Exist";
> + exit 1;
> +fi
> while true
> do
> echo -e "HTTP/1.1 200 OK\r\n\r\nHello from a filesystem image." | nc -l
> "$1"
> diff --git a/src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> b/src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> index c93be9b..094d776 100755
> --- a/src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> +++ b/src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> @@ -514,27 +514,27 @@ trap collect_result EXIT
> aurorabuild all
> setup_ssh
>
> -test_version
> -test_http_example "${TEST_JOB_ARGS[@]}"
> -test_health_check
> +# test_version
> +# test_http_example "${TEST_JOB_ARGS[@]}"
> +# test_health_check
>
> -test_http_example_basic "${TEST_JOB_REVOCABLE_ARGS[@]}"
> +# test_http_example_basic "${TEST_JOB_REVOCABLE_ARGS[@]}"
>
> -test_http_example_basic "${TEST_JOB_GPU_ARGS[@]}"
> +# test_http_example_basic "${TEST_JOB_GPU_ARGS[@]}"
>
> # build the test docker image
> -sudo docker build -t http_example -f "${TEST_ROOT}/Dockerfile.python"
> ${TEST_ROOT}
> -test_http_example "${TEST_JOB_DOCKER_ARGS[@]}"
> +# sudo docker build -t http_example -f "${TEST_ROOT}/Dockerfile.python"
> ${TEST_ROOT}
> +# test_http_example "${TEST_JOB_DOCKER_ARGS[@]}"
>
> setup_image_stores
> test_appc_unified
> -test_docker_unified
> +# test_docker_unified
>
> -test_admin "${TEST_ADMIN_ARGS[@]}"
> -test_basic_auth_unauthenticated "${TEST_JOB_ARGS[@]}"
> +# test_admin "${TEST_ADMIN_ARGS[@]}"
> +# test_basic_auth_unauthenticated "${TEST_JOB_ARGS[@]}"
>
> -test_ephemeral_daemon_with_final
> "${TEST_JOB_EPHEMERAL_DAEMON_WITH_FINAL_ARGS[@]}"
> +# test_ephemeral_daemon_with_final
> "${TEST_JOB_EPHEMERAL_DAEMON_WITH_FINAL_ARGS[@]}"
>
> -/vagrant/src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh
> -/vagrant/src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh
> +# /vagrant/src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh
> +#
> /vagrant/src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh
> RETCODE=0
> --
> 2.10.0
> {noformat}
> You can apply the patch by copying the content to a {{.patch}} file and
> running {{git am < file.patch}}
> Run the e2e tests.
> Observe that the tests fail because the tasks fail. The tasks fail because
> the mountpoint in their sandbox does not exist.
> I observe the correct ContainerInfo being sent to Mesos so I suspect our
> executor is to blame here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
