[ https://issues.apache.org/jira/browse/AURORA-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613357#comment-15613357 ]
Zameer Manji commented on AURORA-1805: -------------------------------------- It still suffers the same string interpolation issues as constructing the command line. > Enhance `Process` object to allow easier access to environment variables > ------------------------------------------------------------------------ > > Key: AURORA-1805 > URL: https://issues.apache.org/jira/browse/AURORA-1805 > Project: Aurora > Issue Type: Task > Components: Thermos > Reporter: Zameer Manji > > The thermos DSL: > {noformat} > class Process(Struct): > cmdline = Required(String) > name = Required(String) > # This is currently unused but reserved for future use by Thermos. > resources = Resources > # optionals > max_failures = Default(Integer, 1) # maximum number of failed process > runs > # before process is failed. > daemon = Default(Boolean, False) > ephemeral = Default(Boolean, False) > min_duration = Default(Integer, 5) # integer seconds > final = Default(Boolean, False) # if this process should be a > finalizing process > # that should always be run after > regular processes > logger = Default(Logger, Empty) > {noformat} > If we can add a new field: > {noformat} > environment = Default(Map(String, String), {}) > {noformat} > It will make it much easier to add environment variables. > Right now the solution is to prefix environment variables to cmdline which > can get janky and frustrating with the string interpolation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)