martin-g commented on a change in pull request #1356:
URL: https://github.com/apache/avro/pull/1356#discussion_r724776338
##########
File path: lang/js/package-lock.json
##########
@@ -1,2260 +1,8 @@
{
"name": "avro-js",
- "version": "1.11.0-SNAPSHOT",
- "lockfileVersion": 2,
+ "version": "1.12.0-SNAPSHOT",
+ "lockfileVersion": 1,
"requires": true,
- "packages": {
Review comment:
For me the best is to use exact versions in package.json for [dev]
dependencies, like `0.11.0`.
Using "smart" versions like `~0.11.0` or `^0.11.0` leads to such kind of
problems. See https://nodejs.dev/learn/the-package-lock-json-file for more.
I think it is OK to merge this PR now, but maybe we should pin the
dependencies' versions for 1.12.0 ?!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
