martin-g commented on a change in pull request #1396:
URL: https://github.com/apache/avro/pull/1396#discussion_r787504710
##########
File path: lang/rust/src/types.rs
##########
@@ -168,7 +173,11 @@ where
T: Into<Self>,
{
fn from(value: Option<T>) -> Self {
- Self::Union(Box::new(value.map_or_else(|| Self::Null, Into::into)))
+ // NOTE: this is incorrect in case first type in union is not "none"
Review comment:
Ignore this comment! I misunderstood it the first time!
It looks OK to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
