zcsizmadia edited a comment on pull request #1569: URL: https://github.com/apache/avro/pull/1569#issuecomment-1052567195
@KyleSchoonover I totally support the idea if increasing the unit test coverage and I want to ake sure that most likely there is nothing wrong with this particular change. The theoritical issue I am having is that changing the original library and new unit test for that change are happening at the same time. My immideate concern is that this is passing fine, however the change in the main library is a potential breaking change somewhere else for someb user downstream. This is probably a good use case IMO to show why changing if conditions and casting and other non-trivial changes should be a low priority. And adding unit tests at the same time can potentially hide breaking changes. I am not saying that if it is not broken, it should not be changed, however for a mature library, like this, the risk appetite IMO should be low. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
