zcsizmadia commented on a change in pull request #1565:
URL: https://github.com/apache/avro/pull/1565#discussion_r814917358
##########
File path: lang/csharp/src/apache/test/Avro.test.csproj
##########
@@ -32,13 +32,22 @@
</PropertyGroup>
<ItemGroup>
+ <PackageReference Include="coverlet.collector"
Version="$(CoverletCollectorVersion)">
+ <PrivateAssets>all</PrivateAssets>
+ <IncludeAssets>runtime; build; native; contentfiles; analyzers;
buildtransitive</IncludeAssets>
+ </PackageReference>
+ <PackageReference Include="coverlet.msbuild"
Version="$(CoverletMSBuildVersion)">
+ <PrivateAssets>all</PrivateAssets>
+ <IncludeAssets>runtime; build; native; contentfiles; analyzers;
buildtransitive</IncludeAssets>
+ </PackageReference>
<PackageReference Include="NUnit" Version="$(NUnitVersion)" />
<PackageReference Include="NUnit3TestAdapter"
Version="$(NUnit3TestAdapterVersion)" />
<PackageReference Include="NUnit.ConsoleRunner"
Version="$(NUnitConsoleRunnerVersion)" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk"
Version="$(MicrosoftNETTestSdkVersion)" />
+ <PackageReference Include="ReportGenerator"
Version="$(ReportGeneratorVersion)" />
Review comment:
This is not needed
##########
File path: lang/csharp/versions.props
##########
@@ -57,5 +57,8 @@
<NUnitConsoleRunnerVersion>3.14.0</NUnitConsoleRunnerVersion>
<NUnit3TestAdapterVersion>4.2.1</NUnit3TestAdapterVersion>
<StyleCopAnalyzersVersion>1.1.118</StyleCopAnalyzersVersion>
+ <CoverletCollectorVersion>3.1.2</CoverletCollectorVersion>
Review comment:
Sort the list plz
##########
File path: lang/csharp/CODECOVERAGE.md
##########
@@ -0,0 +1,8 @@
+# C# Avro Code Coverage
+
+The following instructions should be followed in order to create a code
coverage report locally. Please note that this assumes you are running on
Windows OS and that your local nuget cache is under you user profile.
+
+1. Open a command prompt
+2. Navigate to the test project `avro\lang\csharp\src\apache\test`
+3. Run the following test command `dotnet test --results-directory
./TestResults --collect:"XPlat Code Coverage"`
Review comment:
This could be more convenient and could be running all the time `dotnet
test ...` is running by setting `CollectCoverage` to true and the other needed
props in the csproj file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
