martin-g commented on a change in pull request #1602:
URL: https://github.com/apache/avro/pull/1602#discussion_r826624136
##########
File path: lang/rust/avro/src/encode.rs
##########
@@ -496,4 +495,268 @@ mod tests {
encode(&outer_value2, &schema, &mut buf);
assert!(!buf.is_empty());
}
+
+ #[test]
+ fn test_avro_3448_proper_multi_level_encoding_outer_namespace() {
+ let schema = r#"
+ {
+ "name": "record_name",
+ "namespace": "space",
+ "type": "record",
+ "fields": [
+ {
+ "name": "outer_field_1",
+ "type": [
+ "null",
+ {
+ "type": "record",
+ "name": "middle_record_name",
+ "fields":[
+ {
+ "name":"middle_field_1",
+ "type":[
+ "null",
+ {
+ "type":"record",
+ "name":"inner_record_name",
+ "fields":[
+ {
+ "name":"inner_field_1",
+ "type":"double"
+ }
+ ]
+ }
+ ]
+ }
+ ]
+ }
+ ]
+ },
+ {
+ "name": "outer_field_2",
+ "type" : "space.inner_record_name"
+ }
+ ]
+ }
+ "#;
+ let schema = Schema::parse_str(schema).unwrap();
+ let inner_record = Value::Record(vec![("inner_field_1".into(),
Value::Double(5.4))]);
+ let middle_record_variation_1 = Value::Record(vec![(
+ "middle_field_1".into(),
+ Value::Union(0, Box::new(Value::Null)),
+ )]);
+ let middle_record_variation_2 = Value::Record(vec![(
+ "middle_field_1".into(),
+ Value::Union(1, Box::new(inner_record.clone())),
+ )]);
+ let outer_record_variation_1 = Value::Record(vec![
+ (
+ "outer_field_1".into(),
+ Value::Union(0, Box::new(Value::Null)),
+ ),
+ ("outer_field_2".into(), inner_record.clone()),
+ ]);
+ let outer_record_variation_2 = Value::Record(vec![
+ (
+ "outer_field_1".into(),
+ Value::Union(1, Box::new(middle_record_variation_1)),
+ ),
+ ("outer_field_2".into(), inner_record.clone()),
+ ]);
+ let outer_record_variation_3 = Value::Record(vec![
+ (
+ "outer_field_1".into(),
+ Value::Union(1, Box::new(middle_record_variation_2)),
+ ),
+ ("outer_field_2".into(), inner_record),
+ ]);
+
+ // TODO add in error result wrapping to encoding flow
Review comment:
Agreed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
