jklamer commented on pull request #1602: URL: https://github.com/apache/avro/pull/1602#issuecomment-1070235112
Hey! Pushed some changes to remove the panics from the encode flow plus refactored the naming to match the other modules. Found some other future work that is relevant and related but in the interest avoiding scope creep I want to get some buy-in before I proceed. Things that can be added to this PR that are significant: - Value Resolution flow has the same schema lookup strategy as the encoding, decoding, and parsing flows, which means it has the same potential namespacing issues. The flow can be changed to match the others. Better finding this now rather than later 🙃 - Add in encoded size to the Ok() return from encode. This was discussed but would be a lot of code change not related to the original encoding panic bug that led to this PR. I also added in more future work and breaking change (slight) to the PR's description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
