zcsizmadia commented on a change in pull request #1623:
URL: https://github.com/apache/avro/pull/1623#discussion_r835800789
##########
File path: lang/csharp/src/apache/main/Util/TimeMicrosecond.cs
##########
@@ -50,17 +51,16 @@ public override object ConvertToBaseValue(object
logicalValue, LogicalSchema sch
{
var time = (TimeSpan)logicalValue;
- if (time > _maxTime)
+ if (time >= _maxTime)
throw new ArgumentOutOfRangeException(nameof(logicalValue), "A
'time-micros' value can only have the range '00:00:00' to '23:59:59'.");
Review comment:
I am always paranoid when it comes to changing existing exception
messages. My concern is that the ned user is using a string match to capture
avro extensions, since there are very exception types, and the exceptions are
differentiated by their message.
Additionally, from a human reading point, the message is correct(ish). When
I read it as it is now, my expectation is that it is less than 24 hours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
