KyleSchoonover commented on code in PR #1605:
URL: https://github.com/apache/avro/pull/1605#discussion_r844199217
##########
lang/csharp/src/apache/test/AvroGen/AvroGenHelper.cs:
##########
@@ -93,20 +93,21 @@ public static Assembly
CompileCSharpFilesIntoLibrary(IEnumerable<string> sourceF
{
typeof(object).Assembly.Location,
typeof(Schema).Assembly.Location,
+
typeof(System.CodeDom.Compiler.GeneratedCodeAttribute).Assembly.Location,
Path.Combine(assemblyPath, "System.Runtime.dll"),
Path.Combine(assemblyPath, "netstandard.dll")
};
// Create compiler
CSharpCompilation compilation = CSharpCompilation
- .Create(assemblyName)
- .WithOptions(new
CSharpCompilationOptions(OutputKind.DynamicallyLinkedLibrary))
- .AddReferences(assemblies.Select(path =>
MetadataReference.CreateFromFile(path)))
- .AddSyntaxTrees(sourceFiles.Select(sourceFile =>
- {
- string sourceText =
System.IO.File.ReadAllText(sourceFile);
- return CSharpSyntaxTree.ParseText(sourceText);
- }));
+ .Create(assemblyName)
Review Comment:
Also this formatting is what is default in Visual studio, which we can
potentially override in the editorconfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
